feat(tabs): add bulk close options to tab context menu - #306
Conversation
|
This PR was not deployed automatically as @ifeelBALANCED does not have access to the Railway project. In order to get automatic PR deploys, please add @ifeelBALANCED to your workspace on Railway. |
There was a problem hiding this comment.
Pull request overview
Adds a reusable context menu component to the UI package and wires it into the desktop table tabs to support bulk tab-closing actions via right-click.
Changes:
- Added
@conar/uiContextMenucomponent wrapper (Base UI-based) with Shadcn-style subcomponents. - Integrated a right-click context menu on table tabs with Close / Close Others / Close to the Right / Close All.
- Updated workspace dependencies by removing
@radix-ui/react-context-menu(and lockfile updates).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Removes Radix context-menu from the catalog and updates built-deps list. |
| pnpm-lock.yaml | Lockfile updates reflecting dependency removals. |
| packages/ui/src/components/context-menu.tsx | Introduces a reusable context menu component API for the design system. |
| packages/ui/package.json | Removes @radix-ui/react-context-menu dependency from @conar/ui. |
| apps/desktop/src/routes/_protected/database/$id/table/-components/tabs.tsx | Adds context menu to tabs and implements bulk close actions + prop refactor. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…y options retrieval
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description of Changes
What was changed?
Added context menu component (
packages/ui/src/components/context-menu.tsx)Integrated context menu with tabs (
apps/desktop/src/routes/_protected/database/$id/table/-components/tabs.tsx)SortableTabcomponent props to use a TypeScript interface for better maintainabilityWhy was it changed?
Any related issues or discussions?
This implementation enables right-click functionality on tabs as requested, with support for both desktop and web versions of the application.
Checklist
Closes #305