ws: allow '+' in subprotocol names - #3656
Open
jpfr wants to merge 1 commit into
Open
Conversation
RFC 6455 defines Sec-WebSocket-Protocol values using HTTP token syntax, where '+' is valid. It is used by registered subprotocols such as OPC UA's 'opcua+uacp'. The LWS 5 server upgrade path parses the protocol list with the generic tokenizer. Without LWS_TOKENIZE_F_PLUS_NONTERM, it rejects names containing '+' as a malformed protocol list before the user protocol callback can run. Keep '+' inside the token so normal vhost protocol selection can match these subprotocols.
|
lws-team
force-pushed
the
main
branch
10 times, most recently
from
August 31, 2026 10:48
591ce34 to
bc69b6b
Compare
lws-team
force-pushed
the
main
branch
2 times, most recently
from
September 6, 2026 04:02
106d542 to
d7e586c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 6455 defines Sec-WebSocket-Protocol values using HTTP token syntax, where '+' is valid. It is used by registered subprotocols such as OPC UA's 'opcua+uacp'.
The LWS 5 server upgrade path parses the protocol list with the generic tokenizer. Without LWS_TOKENIZE_F_PLUS_NONTERM, it rejects names containing '+' as a malformed protocol list before the user protocol callback can run.
Keep '+' inside the token so normal vhost protocol selection can match these subprotocols.