fix(validation): reject empty metadata.annotations in manifest#779
Open
madmecodes wants to merge 1 commit into
Open
fix(validation): reject empty metadata.annotations in manifest#779madmecodes wants to merge 1 commit into
madmecodes wants to merge 1 commit into
Conversation
Signed-off-by: madmecodes <ayushguptadev1@gmail.com>
madmecodes
force-pushed
the
fix/empty-annotations-validation
branch
from
7d3ee00 to
34852a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serde(default)toMetadata.annotationsso a null YAML value deserializes without error, allowing validation to runvalidate_metadata_annotationscheck in raw YAML validation to reject manifests wheremetadata.annotationsis present but null or an empty mappingFixes #676
Test plan
cargo test -p wadm-typespassescargo test --test validation validate_empty_annotationspasses, confirming the manifest is correctly rejected