fix: constructor-super false positives in branching/loop/try control flow#1244
Merged
Conversation
…flow Trailing statements after an if/else or switch that already called super() in every branch were incorrectly required to call super() again, and loops/try-catch-finally weren't analyzed at all, causing false positives on common valid patterns.
A super() call inside a loop without a guaranteed break right after it can be revisited on a later iteration, and a finally block always runs after the try block - neither case was flagged as a duplicate.
fansenze
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
constructor-superfalse positives, verified against upstream ESLint (v10.6.0).if/elseboth callsuper(), then other codeswitchall cases callsuper(), then other codewhile (true) { super(); break; }try { super(); } finally {}try { a(); } catch(e){} finally { super(); }while (true) { super(); }(no break)while (true) { super(); continue; }do { super(); } while (true | false);for (;;) { super(); }(no break)try { super(); } finally { super(); }try { super(); } finally {} super();Related Links
Checklist