Map font-face web feature#56644
Conversation
dbaron
left a comment
There was a problem hiding this comment.
This mostly looks good, but I have questions about 2 of the mappings.
There was a problem hiding this comment.
Is the idea of the feature mapping that we map each test to a single feature, or potentially multiple features? These tests are primarily targeting the WOFF font format, so I'd probably be inclined not to call them font-face tests unless we also call them WOFF tests.
There was a problem hiding this comment.
Is the idea of the feature mapping that we map each test to a single feature, or potentially multiple features? These tests are primarily targeting the
WOFFfont format, so I'd probably be inclined not to call themfont-facetests unless we also call themWOFFtests.
The idea is to map to a single feature and going back over this, I agree.
| files: | ||
| - font-face-* | ||
| - downloadable-font-* | ||
| - first-available-font-* |
There was a problem hiding this comment.
I think these first-available-font-* tests also aren't primarily targeting the font-face feature. (see previous comment).
Also, I think this probably should count as a |
# Conflicts: # css/css-fonts/WEB_FEATURES.yml # css/cssom/WEB_FEATURES.yml
Feature: "@font-face"
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/font-face.yml
Notable exclusions:
css/css-fonts/test_datafont_same_origin.html, testing font-face and font-family