Skip to content

Map get-computed-style web-feature#56648

Merged
jcscottiii merged 3 commits into
web-platform-tests:masterfrom
bocoup:get-computed-style-wf
Jan 22, 2026
Merged

Map get-computed-style web-feature#56648
jcscottiii merged 3 commits into
web-platform-tests:masterfrom
bocoup:get-computed-style-wf

Conversation

@stalgiag

Copy link
Copy Markdown
Contributor

Feature: get-computed-style
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/get-computed-style.yml

Hello, reviewers! As of 2025-12-05, the wpt-pr-bot is requesting reviews from code owners for changes to WEB_FEATURES.yml files. To learn more about the purpose of these files, check out this presentation from TPAC 2025, Annotating WPT to Surface the Status of the Platform.

Notable exclusions

  1. Tests for specific CSS properties' computed values (ex: css/filter-effects/parsing/flood-opacity-computed.svg) and other *-computed.html files in specific CSS module directories. These test the computed value of specific properties (like flood-opacity), not the getComputedStyle method itself.

Feature: get-computed-style
Reference: https://github.com/web-platform-dx/web-features/blob/main/features/get-computed-style.yml

Notable exclusions

1. Tests for specific CSS properties' computed values (ex: `css/filter-effects/parsing/flood-opacity-computed.svg`) and other *-computed.html files in specific CSS module directories. These test the computed value of specific properties (like flood-opacity), not the getComputedStyle method itself.
Comment thread css/cssom/WEB_FEATURES.yml Outdated
- HTMLLinkElement-disabled-alternate.html
- name: get-computed-style
files:
- computed-style-*

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe this should map only computed-style-001.html and computed-style-set-property.html; I think the others are really testing specific aspects of the definitions of particular resolved values.

Comment thread css/cssom/WEB_FEATURES.yml Outdated
- name: get-computed-style
files:
- computed-style-*
- getComputedStyle-*

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a bunch of these tests are also about resolved values of specific properties, whereas others are really tests of getComputedStyle itself.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 63ef415. How does that list look?

Here's a breakdown of the excluded getComputedStyle-* tests as of now, per my understanding of your recommendation @dbaron :

@jcscottiii jcscottiii merged commit 6a4b7e5 into web-platform-tests:master Jan 22, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants