Skip to content

maps "toggleevent-source" web feature#58792

Merged
foolip merged 2 commits into
web-platform-tests:masterfrom
bocoup:wf-toggleevent-source
Apr 2, 2026
Merged

maps "toggleevent-source" web feature#58792
foolip merged 2 commits into
web-platform-tests:masterfrom
bocoup:wf-toggleevent-source

Conversation

@ChrisC

@ChrisC ChrisC commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

web feature docs: https://github.com/web-platform-dx/web-features/blob/main/features/toggleevent-source.yml

@foolip I opted to update the mappings in the the-dialog-element to avoid overlap with the "dialog" web feature in 8940582. You signaled that we should eventually do this when we encountered similar overlap situations on the button element recently. If we should keep dialog as is though, I can revert the commit.

cc @jcscottiii @jugglinmike


As of 2025-12-05, the wpt-pr-bot is requesting reviews from code owners for changes to WEB_FEATURES.yml files. To learn more about the purpose of these files, check out this presentation from TPAC 2025, Annotating WPT to Surface the Status of the Platform

@foolip

foolip commented Apr 2, 2026

Copy link
Copy Markdown
Member

@foolip I opted to update the mappings in the the-dialog-element to avoid overlap with the "dialog" web feature in 8940582. You signaled that we should eventually do this when we encountered similar overlap situations on the button element recently. If we should keep dialog as is though, I can revert the commit.

I think it's the right call. I know we have a lot of features with "subfeatures" that overlap, but in general I think avoiding the overlap is better.

@foolip foolip merged commit f17301a into web-platform-tests:master Apr 2, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants