Fix WPT version of scroll-timeilne-snapshotting test#58909
Fix WPT version of scroll-timeilne-snapshotting test#58909chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
The original test has implicit timing assumptions about when events would be dispatched relative to animation frame timing. This test was also failing on webkit, which supports SDA. The updated test, has fewer moving parts (pun intended) and works with or without the snapshot post layout experiment. Fixing as part of Interop 2026 Bug: 384523570 Change-Id: I84c223d7ca8e8aa1c238bd5b099f94a8712c33aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7718838 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1609258}
e9ab052 to
b6e42ec
Compare
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
| await runAndWaitForFrameUpdate(() => { | ||
| timeline = new ScrollTimeline({source: scroller}); | ||
| }); |
There was a problem hiding this comment.
This ought to fix the timeout, but we shouldn't modify this PR:
| await runAndWaitForFrameUpdate(() => { | |
| timeline = new ScrollTimeline({source: scroller}); | |
| }); | |
| await runAndWaitForFrameUpdate(t.step_func(() => { | |
| timeline = new ScrollTimeline({source: scroller}); | |
| })); |
|
With these changes Chrome and Firefox pass the test, but Firefox is a timeout instead of failing fast: @kevers-google I've commented where I think the issue is. Can you pick a fix you like in a follow-up Chromium CL or WPT PR? |
|
A strategy adopted in later tests is to start with something like: or include a CSS rule like at the start of the test, to ensure a deterministic failure path when the feature is not supported. |
The original test has implicit timing assumptions about when
events would be dispatched relative to animation frame timing. This
test was also failing on webkit, which supports SDA.
The updated test, has fewer moving parts (pun intended) and works with
or without the snapshot post layout experiment.
Fixing as part of Interop 2026
Bug: 384523570
Change-Id: I84c223d7ca8e8aa1c238bd5b099f94a8712c33aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7718838
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Olga Gerchikov <gerchiko@microsoft.com>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609258}