feat(plugin-metrics): test pipeline - #5060
Conversation
0754d2f to
bc7e1a2
Compare
github-actions
Bot
removed
the
validated
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc7e1a2a7f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| this.initFailed = true; | ||
| this.logger.error( | ||
| `services: failed to init initial services when credentials available, ${error?.message}` | ||
| `services: failed to init services when credentials available, ${error?.message}` |
There was a problem hiding this comment.
When initServiceCatalogs() rejects while credentials are present, the existing unit test in packages/@webex/webex-core/test/unit/spec/services/services.js:120-123 still asserts that logger.error receives the old services: failed to init initial services... message. This changed literal makes that rejection-path test fail until the expectation is updated or the log text is restored.
Useful? React with 👍 / 👎.
| this.initFailed = true; | ||
| this.logger.error( | ||
| `services: failed to init initial services when credentials available, ${error?.message}` | ||
| `services: failed to init services when credentials available, ${error?.message}` |
There was a problem hiding this comment.
The services-v2 rejection-path test in packages/@webex/webex-core/test/unit/spec/services-v2/services-v2.ts:122-125 still checks for services: failed to init initial services... when credentials exist and initServiceCatalogs() rejects. Because this changed string no longer matches that assertion, the services-v2 unit suite fails unless the test or log message is updated consistently.
Useful? React with 👍 / 👎.
bc7e1a2 to
7313bb2
Compare
github-actions
Bot
removed
the
validated
7313bb2 to
a29fd99
Compare
github-actions
Bot
removed
the
validated
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a29fd999d0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| sinon.assert.calledWith( | ||
| services.logger.error, | ||
| `services: failed to init initial services when no credentials available, ${expectedMessage}` | ||
| `services: failed to init services when no credentials available, ${expectedMessage}` |
There was a problem hiding this comment.
When this no-credentials rejection path runs, Services._initializeCatalogsUngated() still logs services: failed to init initial services when no credentials available, ... in packages/@webex/webex-core/src/lib/services/services.js:1498. This updated assertion drops initial, so both parameterized collectPreauthCatalog failure cases fail even though the implementation under test has not changed on that branch.
Useful? React with 👍 / 👎.
| sinon.assert.calledWith( | ||
| services.logger.error, | ||
| `services: failed to init initial services when no credentials available, ${expectedMessage}` | ||
| `services: failed to init services when no credentials available, ${expectedMessage}` |
There was a problem hiding this comment.
When this no-credentials rejection path runs, ServicesV2._initializeCatalogsUngated() still logs services: failed to init initial services when no credentials available, ... in packages/@webex/webex-core/src/lib/services-v2/services-v2.ts:1457. This updated assertion drops initial, so both parameterized collectPreauthCatalog failure cases fail even though the implementation under test has not changed on that branch.
Useful? React with 👍 / 👎.
2 participants
dummy merge