fix(webex-core): bound services readiness by startup deadline - #5140
Open
robstax wants to merge 1 commit into
Open
fix(webex-core): bound services readiness by startup deadline#5140robstax wants to merge 1 commit into
robstax wants to merge 1 commit into
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES #N/A
No linked issue. This is an SDK follow-up to WebexServices/webex-web-client#11544.
This pull request addresses
When
services.waitForCatalogInitis enabled, catalog initialization is bounded bycatalogInitTimeout, but readiness finalization can subsequently wait without a timeout while credentials are refreshing. A refresh that remains in flight can therefore keepservices.readyandwebex.readypending beyond the advertised startup bound.by making the following changes
Change Type
The following scenarios were tested
yarn workspace @webex/webex-core build:srcyarn workspace @webex/webex-core test:unit --targets services/services.js— 78 tests passed.yarn workspace @webex/webex-core test:unit --targets services-v2/services-v2.ts— 81 tests passed.yarn lint:staged— ESLint passed for all four changed files.services.ready; disabled passed.The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.