fix(cc-widgets): update the workflow for pull request by adding the required env variables - #480
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
| }} | ||
| /> | ||
| <Checkbox | ||
| data-testid="samples:show-agent-profile-checkbox" |
There was a problem hiding this comment.
Why can't this change or any change of this file be part of your PR rather a pre-requisite?
There was a problem hiding this comment.
I think the e2e tests which run when I raise my user state PR need these changes to be there in the main repo …because the tests will be using those env values and the data testids which are not currently present in App.tsx of the base repo
There was a problem hiding this comment.
Shouldn't the tests run on the downstream repo's code and not on the upstream one?
There was a problem hiding this comment.
Yeah you are right. I have modified the PR to address only the workflow change
mkesavan13
left a comment
There was a problem hiding this comment.
Just one nitpick comment. Approving
|
|
||
| - name: Test CC Widgets | ||
| run: yarn run test:cc-widgets | ||
| run: yarn run test:cc-widgets No newline at end of file |
There was a problem hiding this comment.
Let's add back that empty line
# [1.28.0-ccwidgets.79](v1.28.0-ccwidgets.78...v1.28.0-ccwidgets.79) (2025-06-26) ### Bug Fixes * **cc-widgets:** update the workflow for pull request by adding the required env variables ([#480](#480)) ([247ca45](247ca45))
|
🎉 This PR is included in version 1.28.0-ccwidgets.79 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
COMPLETES #Adhoc
This pull request addresses
The change in the workflow for UI Automation
by making the following changes
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging