Skip to content

fix(cc-widgets): add email credentials to the workflow #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkesavan13 merged 3 commits into from
Jul 11, 2025
Merged

fix(cc-widgets): add email credentials to the workflow #493

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd06501
fix(cc-widgets): add email credentials to workflow
riteshfyi Jul 8, 2025
e21965d
fix(cc-widgets): update email env variable in workflow
riteshfyi Jul 8, 2025
fee5314
fix(cc-widgets): update email entrypoint name in workflow
riteshfyi Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ env:
PW_DIAL_NUMBER: ${{ secrets.PW_DIAL_NUMBER }}
PW_AGENT2_USERNAME: ${{ secrets.PW_AGENT2_USERNAME }}
PW_AGENT2_EXTENSION_NUMBER: ${{ secrets.PW_AGENT2_EXTENSION_NUMBER }}
PW_SENDER_EMAIL : ${{ secrets.PW_SENDER_EMAIL }}
PW_EMAIL_ENDPOINT: ${{ secrets.PW_EMAIL_ENDPOINT }}
PW_APP_PASSWORD: ${{ secrets.PW_APP_PASSWORD }}
Comment on lines +24 to +26

@mkesavan13 mkesavan13 Jul 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also please add it in the description, what each of these variables are used for?

@mkesavan13 mkesavan13 Jul 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why do we need the email end point in the secrets? Can't it be kept in the tests file itself?

@riteshfyi riteshfyi Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do that as well.

@riteshfyi riteshfyi Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our discussion that having email entry point or the sender email in the public repo can open the possibilites of spam, so to avoid that we are using secrets.


jobs:
validate:
Expand Down
8 changes: 4 additions & 4 deletions ...enter/cc-components/tests/components/UserState/__snapshots__/user-state.snapshot.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ exports[`UserState Component Snapshots Interactions should handle custom state r
</div>
`;

exports[`UserState Component Snapshots Rendering should not render elapsed time when customState is present 1`] = `
exports[`UserState Component Snapshots Rendering - Tests for UI elements and visual states of UserState component should not render elapsed time when customState is present 1`] = `

@mkesavan13 mkesavan13 Jul 8, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add why we have these changes in the PR description?

@riteshfyi riteshfyi Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to some reason the pre-commit tests were failing, i had a chat with shreyas regarding that. he told me that there is some issue that he will take care of & told me to add this file as well. so, after adding those change the pre-commit tests passed.

@Shreyas281299 Shreyas281299 Jul 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkesavan13 this was a miss on my part, the PR that went in before was my PR for unit test for user state, there I updated the description for 1 of the tests but didnt update the snapshots, hence the pre-commit checks were failling for Ritesh. I had asked him to update the snapshot.

<div
class="user-state-container"
data-testid="user-state-container"
Expand Down Expand Up @@ -415,7 +415,7 @@ exports[`UserState Component Snapshots Rendering should not render elapsed time
</div>
`;

exports[`UserState Component Snapshots Rendering should render elapsed time with disabled class when isSettingAgentStatus is true 1`] = `
exports[`UserState Component Snapshots Rendering - Tests for UI elements and visual states of UserState component should render elapsed time with disabled class when isSettingAgentStatus is true 1`] = `
<div
class="user-state-container"
data-testid="user-state-container"
Expand Down Expand Up @@ -558,7 +558,7 @@ exports[`UserState Component Snapshots Rendering should render elapsed time with
</div>
`;

exports[`UserState Component Snapshots Rendering should render elapsed time without lastIdleStateChangeElapsedTime when negative 1`] = `
exports[`UserState Component Snapshots Rendering - Tests for UI elements and visual states of UserState component should render elapsed time without lastIdleStateChangeElapsedTime when negative 1`] = `
<div
class="user-state-container"
data-testid="user-state-container"
Expand Down Expand Up @@ -700,7 +700,7 @@ exports[`UserState Component Snapshots Rendering should render elapsed time with
</div>
`;

exports[`UserState Component Snapshots Rendering should render the component with correct elements 1`] = `
exports[`UserState Component Snapshots Rendering - Tests for UI elements and visual states of UserState component should render the component with correct elements 1`] = `
<div
class="user-state-container"
data-testid="user-state-container"
Expand Down