Skip to content

fix: verify e2e tests after updating machine config #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riteshfyi merged 8 commits into from
Jun 29, 2026
Merged

fix: verify e2e tests after updating machine config #708

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5a5c430
feat: test e2e
riteshfyi Jun 24, 2026
73d3dae
fix: remove dummy comment
riteshfyi Jun 24, 2026
52464d3
bump playwright versions
riteshfyi Jun 24, 2026
0fa3ac3
fix: add space
riteshfyi Jun 24, 2026
97d7684
fix: update lock file
riteshfyi Jun 24, 2026
e7b5049
fix: try with 1.61.1
riteshfyi Jun 24, 2026
ad7f48a
update machine config
riteshfyi Jun 29, 2026
b030fa2
fix spelling
riteshfyi Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ jobs:

e2e_test_cc_widgets:
timeout-minutes: 50
runs-on: ubuntu-latest
runs-on: ubuntu-latest-4-core

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the valid 4-core runner label

If this is intended to target GitHub's default 4-core larger Ubuntu runner, the label is misspelled: GitHub lists the 4-core Ubuntu label as ubuntu-latest-4-cores (plural) in its larger-runner announcement (https://github.blog/changelog/2022-10-20-github-actions-larger-hosted-runners-are-now-automatically-created-for-customers/). With the singular ubuntu-latest-4-core, the e2e_test_cc_widgets job will remain queued or fail to find a matching runner whenever the run_e2e label triggers it, unless the organization has created a custom runner with exactly this nonstandard label.

Useful? React with 👍 / 👎.

@riteshfyi riteshfyi Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks goat

needs: [install, build]
if: contains(toJson(github.event.pull_request.labels), 'run_e2e')
concurrency:
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"devDependencies": {
"@babel/plugin-transform-runtime": "^7.29.0",
"@babel/preset-typescript": "7.25.9",
"@playwright/test": "^1.51.1",
"@playwright/test": "^1.61.1",
"@semantic-release/changelog": "^6.0.3",
"@semantic-release/exec": "^6.0.3",
"@semantic-release/git": "^10.0.1",
Expand Down
30 changes: 15 additions & 15 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4914,14 +4914,14 @@ __metadata:
languageName: node
linkType: hard

"@playwright/test@npm:^1.51.1":
version: 1.51.1
resolution: "@playwright/test@npm:1.51.1"
"@playwright/test@npm:^1.61.1":
version: 1.61.1
resolution: "@playwright/test@npm:1.61.1"
dependencies:
playwright: "npm:1.51.1"
playwright: "npm:1.61.1"
bin:
playwright: cli.js
checksum: 10c0/bdb98f3df58f60b5c62e6d5c79c30910404d1855afea0803af0efd6dc63f90c473dbf92ff7dc212f1459f1d32c85dc44a60f70c2e0ea604f975b953d59523234
checksum: 10c0/45004139eaa7c7ec8129e4ed77a9d734aa09ed40b69162b871e4123f1d70217b7b73651431a9343ed5090d5fed11c6df1bff2a56ff4b87dc7b0371b5da87cf9c
languageName: node
linkType: hard

Expand Down Expand Up @@ -27933,27 +27933,27 @@ __metadata:
languageName: node
linkType: hard

"playwright-core@npm:1.51.1":
version: 1.51.1
resolution: "playwright-core@npm:1.51.1"
"playwright-core@npm:1.61.1":
version: 1.61.1
resolution: "playwright-core@npm:1.61.1"
bin:
playwright-core: cli.js
checksum: 10c0/4f004d9dea5ecbd76b84c858fa4880ed955600b6cda972a3e8093ea47e150ce20bf2ea806e73e740497d34f4b61b080c208339a661fc75ad04d8f00bedcc21e0
checksum: 10c0/c28896ba82a602182e240ed4f9c467fb0dd9cb57d510f8aba9f25183fe1cde3a0105725a29baffa4157fe885bbb11e228032a2aad0424111584fde45303f07bd
languageName: node
linkType: hard

"playwright@npm:1.51.1":
version: 1.51.1
resolution: "playwright@npm:1.51.1"
"playwright@npm:1.61.1":
version: 1.61.1
resolution: "playwright@npm:1.61.1"
dependencies:
fsevents: "npm:2.3.2"
playwright-core: "npm:1.51.1"
playwright-core: "npm:1.61.1"
dependenciesMeta:
fsevents:
optional: true
bin:
playwright: cli.js
checksum: 10c0/2aea553b8b1086ee419e72c9d4f4117686e6bdb5e09e0f47dfe563ce0f0bd79c4ee79dd9c8a0f023a2fb7803b81d4fdc552887410d16c036be07f21ab72b3f46
checksum: 10c0/cea1bc4d2a64ec3ef683891606774029da7b8a8036ed98332565cec2f8e89549ca1fab9a89fbfba4e08e27e0d7e7d148031e965af66d5ff97bb3c34058cfcad0
languageName: node
linkType: hard

Expand Down Expand Up @@ -34538,7 +34538,7 @@ __metadata:
"@babel/preset-typescript": "npm:7.25.9"
"@momentum-design/brand-visuals": "npm:^0.30.0"
"@momentum-design/illustrations": "npm:^0.3.0"
"@playwright/test": "npm:^1.51.1"
"@playwright/test": "npm:^1.61.1"
"@semantic-release/changelog": "npm:^6.0.3"
"@semantic-release/exec": "npm:^6.0.3"
"@semantic-release/git": "npm:^10.0.1"
Expand Down
Loading