Skip to content
This repository was archived by the owner on Sep 9, 2021. It is now read-only.

fix: make inline workers work from IE/Edge legacy#316

Open
elasim wants to merge 1 commit into
webpack-contrib:masterfrom
elasim:bugfix/issue-292/workaround
Open

fix: make inline workers work from IE/Edge legacy#316
elasim wants to merge 1 commit into
webpack-contrib:masterfrom
elasim:bugfix/issue-292/workaround

Conversation

@elasim

@elasim elasim commented May 11, 2021

Copy link
Copy Markdown

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Breaking Changes

No breaking changes.

Additional Info

N/A

Schedule object url revoking when setImmediate is available.
@codecov

codecov Bot commented May 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #316 (3b1e9d2) into master (22275e9) will decrease coverage by 22.19%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #316       +/-   ##
===========================================
- Coverage   75.83%   53.64%   -22.20%     
===========================================
  Files           6        6               
  Lines         149      151        +2     
  Branches       52       53        +1     
===========================================
- Hits          113       81       -32     
- Misses         30       54       +24     
- Partials        6       16       +10     
Impacted Files Coverage Δ
src/runtime/inline.js 0.00% <0.00%> (ø)
src/supportWebpack5.js 0.00% <0.00%> (-83.34%) ⬇️
src/index.js 82.50% <0.00%> (-12.50%) ⬇️
src/utils.js 81.57% <0.00%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22275e9...3b1e9d2. Read the comment docs.

@alexander-akait

Copy link
Copy Markdown
Member

Can you accept CLA?

@elasim

elasim commented May 11, 2021

Copy link
Copy Markdown
Author

Okay. I accepted CLA.

@alexander-akait

Copy link
Copy Markdown
Member

I will fix tests tomorrow and do release

@elasim

elasim commented May 11, 2021

Copy link
Copy Markdown
Author

Good. Thanks for your efforts.

@elasim

elasim commented May 11, 2021

Copy link
Copy Markdown
Author

I've found a minor glitch for this approach.

#292 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants