Skip to content

chore(ci): remove redundant tag triggers#1863

Merged
webpro merged 1 commit into
webpro-nl:mainfrom
trueberryless:ci/remove-tags-anti-triggers
Jul 7, 2026
Merged

chore(ci): remove redundant tag triggers#1863
webpro merged 1 commit into
webpro-nl:mainfrom
trueberryless:ci/remove-tags-anti-triggers

Conversation

@trueberryless

Copy link
Copy Markdown
Contributor

Description

This PR removes all the "anti" tag triggers, which were added in this commit to not trigger CI on tag creations, but because the triggers already specify that they should only trigger on branches, this ! trigger is redundant.

This is the last improvement I have planned after discussing about CI in #1849

@pkg-pr-new

pkg-pr-new Bot commented Jul 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/knip@1863
npm i https://pkg.pr.new/@knip/language-server@1863
npm i https://pkg.pr.new/@knip/mcp@1863

commit: a50e5f1

@webpro

webpro commented Jul 5, 2026

Copy link
Copy Markdown
Member

Thanks! I vaguely remember trying to fix that with a release the pipelines runs twice. Does that make sense?

@trueberryless

Copy link
Copy Markdown
Contributor Author

Thanks! I vaguely remember trying to fix that with a release the pipelines runs twice. Does that make sense?

I'm not that familiar with release-it, does it create some temporary branch when releasing? That could be a reason for why it runs twice. But I strongly believe that the current tag triggers do nothing because it only runs on branches, so it ignores tags already.

I mean worst case is that we must revert this, but I highly doubt that this would be necessary...

@webpro

webpro commented Jul 5, 2026

Copy link
Copy Markdown
Member

This is separate from release-it. It's just that we push a branch (i.e. main) and tag on release and I think it ran everything twice. I can try it with the next release.

@webpro
webpro merged commit c61d008 into webpro-nl:main Jul 7, 2026
30 checks passed
@trueberryless
trueberryless deleted the ci/remove-tags-anti-triggers branch July 7, 2026 08:24
@webpro

webpro commented Jul 7, 2026

Copy link
Copy Markdown
Member

🚀 This pull request is included in v6.25.0. See Release 6.25.0 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

@webpro

webpro commented Jul 7, 2026

Copy link
Copy Markdown
Member

Nice, redundant indeed! And now we would likely even still be covered by #1857.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants