fix(test): stop viewer resources before temp-dir cleanup - #135
Merged
Conversation
souloss
added a commit
to souloss/cc-viewer
that referenced
this pull request
Jul 20, 2026
…s now fixed in PR weiesky#135) This branch's own changes (cc-switch SQLITE_BUSY import fix) were verified locally and never the cause of CI red — every CI run on this branch failed only on the pre-existing brotli/SSE-compression/portsBusy timing flake that affects main itself. PR weiesky#135 (fix/ci-flakes-brotli-rmsync, now CI-green) eliminates that flake, so this empty commit retriggers CI to confirm this branch is green with the flake gone.
weiesky
force-pushed
the
fix/ci-flakes-brotli-rmsync
branch
from
July 28, 2026 15:23
4efaa57 to
c768e8b
Compare
weiesky
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased onto the latest
main. The deterministic Brotli fixes are already present onmainvia42207f7, so this PR now focuses only on the remaining CLI-test cleanup race.server.jsresources before removing the isolatedCCV_LOG_DIR.branch-serverteardown.fs.promises.rmand its nativemaxRetries/retryDelaysupport, including transientEBUSY,ENOTEMPTY, andEPERMfailures.os.tmpdir().Verification
npm run build— passes.npm run test:cli— 8,658 pass, 1 fail, 13 skipped. The sole ripgrep.gitignorefailure reproduces unchanged on a clean latest-mainworktree in this environment.