Made SNMP privacy protocol selectable#41
Conversation
wernerfred
left a comment
There was a problem hiding this comment.
LGTM 👍🏻
Please add the new option [-s [AES128|DES]] to the usage in the README.md accordingly.
Why specifically did you choose -s? Maybe we should change this to -e(encryption?) to save -s for future usecases that are more related to the letter s? What's your opinion on that?
Done!
Yes you are right! I was thinking in the direction of "secret". But that would not be logical and also wrong in terms of content. |
wernerfred
left a comment
There was a problem hiding this comment.
Small whitespace fix, rest LGTM 👍🏻
|
@all-contributors add @dommi22m for code |
|
I've put up a pull request to add @dommi22m! 🎉 |
This is my version to make the privacy protocol selectable. AES128 is used as default.