Match pretty-format-toml inline table style in the template - #251
Open
jefftriplett wants to merge 2 commits into
Open
jefftriplett wants to merge 2 commits into
jefftriplett wants to merge 2 commits into
Conversation
pretty-format-toml changed its inline table style to pad braces with
spaces. The committed files were autofixed by pre-commit.ci, but the
copier template still emitted the old style, so every generated example
was reformatted the moment `just generate-examples` linted it.
A hook that modifies a file exits non-zero, which failed `just lint`,
which failed copier's task, which failed generate-example — for all
three examples:
Pretty format TOML.....................................Failed
- hook id: pretty-format-toml
- files were modified by this hook
File examples/calver_inc/pyproject.toml is not pretty-formatted
Emitting the padded style means there is nothing left to reformat.
Only the two real inline tables are changed. The bumpver format strings
below them ({version}, {old_version}) are not TOML tables and are left
alone.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copier template still emitted the old
pretty-format-tomlinline-table style, so the hook reformatted every generated example and failedexamples / generate. Emitting the padded style leaves nothing to reformat.