Skip to content

feat: add signal to EIP1193RequestOptions - #3840

Closed
deodad wants to merge 10 commits into
wevm:mainfrom
deodad:td/abort
Closed

deodad wants to merge 10 commits into
wevm:mainfrom
deodad:td/abort

Conversation

@deodad

@deodad deodad commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator

This PR address #1701. If the approach looks good I'll extrapolate to the rest of the actions where this makes sense.

@changeset-bot

changeset-bot Bot commented Aug 5, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5ed05d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@deodad
deodad force-pushed the td/abort branch 2 times, most recently from 226d74f to eb84560 Compare August 5, 2025 01:13

@tmm tmm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited for this! Some random code style feedback.

Comment thread src/utils/buildRequest.ts
Comment thread src/utils/buildRequest.ts Outdated
Comment thread src/utils/buildRequest.test.ts Outdated
Comment thread src/clients/transports/http.ts Outdated
Comment thread src/clients/transports/http.ts Outdated
@deodad

deodad commented Aug 5, 2025

Copy link
Copy Markdown
Collaborator Author

Excited for this! Some random code style feedback.

thanks—applied

@jxom

jxom commented Aug 7, 2025

Copy link
Copy Markdown
Member

Happy to continue with the other Actions too.

@deodad

deodad commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator Author

I took an initial stab at it. It's ok but having done it this way it might more sense to figure out all the changes required for an action and then go through each one and apply all the changes:

  1. accept requestOptions
  2. make sure RequestErrorType is included in the error type
  3. update the docs page to include requestOptions

a couple others that I'm not sure about but seemed useful:

  1. add a test case to the actions tests for requestOptions. wasn't sure if adding to each action is worth it or too redudant
  2. explicit handling of request errors in catches. for actions that have extra handling that wrap errors in a specific error type would it make sense to check for AbortError or generally for non-base errors and instead immediately rethrow unwrapped?

@MKRhere

MKRhere commented Sep 9, 2025

Copy link
Copy Markdown

Not to bother, but could we update this branch from main and avoid it going stale? I've been watching this PR eagerly :)

@pkg-pr-new

pkg-pr-new Bot commented Jan 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/viem@3840

commit: 5ed05d1

@deodad

deodad commented Jan 5, 2026

Copy link
Copy Markdown
Collaborator Author

brought this PR up to date—think it could be reviewed and merged.

should docs be updated for every action to include requestOptions?

@jxom
jxom force-pushed the main branch 2 times, most recently from bdf8494 to 69e0d6e Compare March 13, 2026 22:42
@vercel

vercel Bot commented May 5, 2026

Copy link
Copy Markdown

@deodad is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercel Bot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
viem Ready Ready Preview, Comment May 5, 2026 8:40pm

Request Review

@tmm

tmm commented May 6, 2026

Copy link
Copy Markdown
Member

Closing in favor of #4584

@tmm tmm closed this May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants