Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@Eras256 is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 36cbc4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5082
Summary
shouldRetryhandles the JSON-RPC-level429code (Alchemy's rate-limitsignal, added in #4424) but doesn't handle QuickNode's own non-standard
rate-limit code,
-32007("N/second request limit reached..."). Thismeans
retryCounton thehttp()transport is silently ignored forQuickNode rate limits specifically — the request fails on the very first
attempt regardless of how high
retryCountis set.This isn't hypothetical: it's the exact failure mode that caused a real
production incident for us against a QuickNode Base endpoint.
error.code === -32007to the retryable codes inshouldRetry,mirroring the existing
429special-case.shouldRetrywith a-32007error code,matching the style of the existing
429test.Test plan
src/utils/buildRequest.test.ts— newshouldRetry > RPC code -32007 (QuickNode rate limit)test.Foundry/Anvil toolchain this sandbox doesn't have), so I also verified
the exact patched branching logic in isolation against six cases
(the new
-32007case, the three already-passing retryable codes,and two non-retryable codes) before opening this PR.