fix(core): clean up injected switchChain listener on failure#5126
Open
yuyua9 wants to merge 1 commit into
Open
fix(core): clean up injected switchChain listener on failure#5126yuyua9 wants to merge 1 commit into
yuyua9 wants to merge 1 commit into
Conversation
|
@yuyua9 is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 1a5aa86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changelistener whenswitchChainfails before the chain-change confirmation arriveswallet_addEthereumChainretry flow, and clean it up if that retry fails@wagmi/coreThis mirrors the leak pattern fixed for WalletConnect in #5033 and the behavior reported in #5032, but applies it to the injected connector path that still had the same failure cleanup gap.
Tests
pnpm dlx @biomejs/biome@2.2.4 check packages/core/src/connectors/injected.ts packages/core/src/connectors/injected.test.ts .changeset/injected-switchchain-listener-leak.mdgit diff --check HEAD~1..HEADNot run successfully:
pnpm exec vitest packages/core/src/connectors/injected.test.ts --run(blocked becausevitestwas unavailable;pnpm install --frozen-lockfile --ignore-scriptsrepeatedly failed with registryECONNRESETbefore dependencies were fully installed)