Make it clearer that static and namespace attrs don't get to have state. Fixes #1133#1135
Open
tabatkins wants to merge 3 commits intowhatwg:mainfrom
Open
Make it clearer that static and namespace attrs don't get to have state. Fixes #1133#1135tabatkins wants to merge 3 commits intowhatwg:mainfrom
tabatkins wants to merge 3 commits intowhatwg:mainfrom
Conversation
annevk
reviewed
May 2, 2022
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
I think this introduces some scoping issues. R isn't accessible outside the inner steps.
idlObject also isn't initialized with "Let" anymore.
Contributor
Author
|
Good catches, fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #1133, interface objects themselves, and namespaces, aren't intended to have complex internal state, so the algo creating their attribute getters (aka statics for interfaces, or regulars for namespaces) didn't give the "getter steps" access to the object themselves and instead called them with null.
This was somewhat implicit in the algo, so this is a light editorial restructuring that makes it more explicit, and adds a short note explaining it.
Preview | Diff