Limit the special case in the [[Set]] algorithm to [OverrideBuiltins] interfaces#715
Open
Limit the special case in the [[Set]] algorithm to [OverrideBuiltins] interfaces#715
Conversation
… interfaces This is the case where it makes most sense, since the prototype chain can't shadow any properties. This change does not affect normal usage; it is only detectable by messing with the prototype of the object. The majority of implementations (Gecko and Chrome) already follow the proposed change; WebKit follows the existing spec. Fixes #630.
ericramos1980
approved these changes
Sep 17, 2019
annevk
approved these changes
Apr 30, 2020
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
Are there web-platform-tests for this change and do we have a bug against WebKit?
Contributor
|
If we do this, then https://github.com/web-platform-tests/wpt/blob/master/webstorage/set.window.js will start failing in the same way as it fails for WebIDL2JS, which currently has a buggy implementation of this (jsdom/webidl2js#218), which causes the special case to always be skipped due to This is because the last test case of https://github.com/web-platform-tests/wpt/blob/master/webstorage/set.window.js currently checks that |
domenic
added
the
needs tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the case where it makes most sense, since the prototype chain can't
shadow any properties.
This change does not affect normal usage; it is only detectable by messing with
the prototype of the object.
The majority of implementations (Gecko and Chrome) already follow the proposed
change; WebKit follows the existing spec.
Fixes #630.