Skip to content

Fix Dialyzer failure on OTP 29 #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whatyouhide merged 2 commits into from
Jun 30, 2026
Merged

Fix Dialyzer failure on OTP 29 #226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b3661e
Suppress false-positive Dialyzer opacity warnings on OTP 29
whatyouhide Jun 30, 2026
08ccd01
Use Date.compare/2 instead of Date.before?/2 for Elixir 1.14 support
whatyouhide Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/stream_data.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,6 +1087,11 @@ defmodule StreamData do
end)
end

# Dialyzer on OTP 29+ reports false-positive opacity warnings because the
# `seen` MapSet accumulator is threaded through these recursive clauses. We
# only ever touch it through the MapSet API, so the warnings are spurious.
@dialyzer {:nowarn_function, uniq_list_of: 9}

defp uniq_list_of(
_data,
_uniq_fun,
Expand Down Expand Up @@ -2171,7 +2176,7 @@ defmodule StreamData do
map(positive_integer(), &Date.add(min, &1))

{min = %Date{}, max = %Date{}, nil} ->
if Date.before?(max, min) do
if Date.compare(max, min) == :lt do
raise ArgumentError, """
expected :max to be after or equal to :min, got:

Expand Down
Loading