enforce KMS-SSE requests to CloudTrail bucket#736
Open
ab77 wants to merge 1 commit intowiddix:masterfrom
Open
Conversation
ab77
force-pushed
the
ab77/cloudtrail-sse
branch
from
71a8deb to
60d9e7c
Compare
Contributor
michaelwittig
left a comment
michaelwittig
left a comment
There was a problem hiding this comment.
Hi added one tiny comment. I like the overall idea!
ab77
force-pushed
the
ab77/cloudtrail-sse
branch
from
be5ffbd to
c62e8dc
Compare
ab77
changed the title
ab77
force-pushed
the
ab77/cloudtrail-sse
branch
2 times, most recently
from
2254d9c to
ac04ad2
Compare
ab77
force-pushed
the
ab77/cloudtrail-sse
branch
from
ac04ad2 to
bac64c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Override all values in parentheses)
(Run
yamllint folder/template.yaml,cfn-lint -i E1019 E3002 E2520 -t folder/template.yaml, andaws cloudformation validate-template --template-body file://folder/template.yamlbefore you open a PR)(Do not include multiple changes in one PR. Open additional PRs instead.)
Add bucket policy to enforce encryption by default using S3-SSE key. Required by ISO 27001 2022/SOC 2/GDPR controls: