refactor: Make late-stage layout phase platform interface more flexible#2089
Open
davidlattimore wants to merge 3 commits into
Open
refactor: Make late-stage layout phase platform interface more flexible#2089davidlattimore wants to merge 3 commits into
davidlattimore wants to merge 3 commits into
Conversation
Member
Author
|
Issue #2075 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three commits. One creates FinaliseSizesExt, where previously we just uses LayoutExt. For now all
Platformimplementations use the same type for bothFinaliseSizesExtandLayoutExt, but that will likely change later. The second commit passes Groups states directly tocreate_finalise_sizes_ext, where previously we passed an iterator over objects. The last commit is just a rename to a more general and more consistent name.