[WFCORE-7668] ParameterArgumentValidationErrorEmptyStringNotAllowed on domain.ps1

[lvydra]

https://redhat.atlassian.net/browse/WFCORE-7668

[yersan]

@lvydra do we know exactly where the HOST_CONTROLLER_JAVA_OPTS is initialized to null when using --version/--help or its variants?

[lvydra]

@yersan Originally, HOST_CONTROLLER JAVA_OPTS is initialized at

wildfly-core/core-feature-pack/common/src/main/resources/content/bin/domain.conf.ps1

Line 84 in 31551b8

$HOST_CONTROLLER_JAVA_OPTS=$JAVA_OPTS

, but after changes, when the script is run using --version/--help, initialization is skipped

wildfly-core/core-feature-pack/common/src/main/resources/content/bin/domain.ps1

Line 13 in 31551b8

if ($global:VERSION) {

, and it remains undeclared, implicitly null.

[yersan]

Ok, so PROCESS_CONTROLLER_JAVA_OPTS has the same problem. inst't it?

I suggest to initialize them at https://github.com/wildfly/wildfly-core/blob/main/core-feature-pack/common/src/main/resources/content/bin/domain.ps1#L23-L28 with the following:

  if ((-Not(Test-Path variable:PROCESS_CONTROLLER_JAVA_OPTS)) -or (-Not($PROCESS_CONTROLLER_JAVA_OPTS))) {
      $PROCESS_CONTROLLER_JAVA_OPTS = Get-Java-Opts
  }
  if ((-Not(Test-Path variable:HOST_CONTROLLER_JAVA_OPTS)) -or (-Not($HOST_CONTROLLER_JAVA_OPTS))) {
      $HOST_CONTROLLER_JAVA_OPTS = Get-Java-Opts
  }

I would expect them to be initialized with the existing Java options

[lvydra]

@yersan I have rebased the commit, and it seems that the changes in e6ee679 are enough to resolve the issue. I have left an update of the tests in the commit to verify that.

[yersan]

@lvydra scripts are failing with this change, could you take a closer look?

[yersan]

Ok, so PROCESS_CONTROLLER_JAVA_OPTS has the same problem. inst't it?

I suggest to initialize them at https://github.com/wildfly/wildfly-core/blob/main/core-feature-pack/common/src/main/resources/content/bin/domain.ps1#L23-L28 with the following:

  if ((-Not(Test-Path variable:PROCESS_CONTROLLER_JAVA_OPTS)) -or (-Not($PROCESS_CONTROLLER_JAVA_OPTS))) {
      $PROCESS_CONTROLLER_JAVA_OPTS = Get-Java-Opts
  }
  if ((-Not(Test-Path variable:HOST_CONTROLLER_JAVA_OPTS)) -or (-Not($HOST_CONTROLLER_JAVA_OPTS))) {
      $HOST_CONTROLLER_JAVA_OPTS = Get-Java-Opts
  }

I would expect them to be initialized with the existing Java options

[lvydra]

@yersan Sure, I will look at it.

[yersan]

Weird, it looks like those test are already silently failing, correct me if I am wrong @lvydra I assume you are looking closely to them

[lvydra]

@yersan Yes, that's true. There is only a check for the expected arguments in the JAVA_OPTS output and not for successful execution.