fix: support rtmps streams#87
Open
kamikazechaser wants to merge 1 commit into
Open
Conversation
This is specific to supporting Kick. jellyfin-ffmpeg already supports rtmps so we only need to alter the regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is specific to supporting Kick.
jellyfin-ffmpegalready supports rtmps so we only need to alter the regex. Without it, stream-sprout returns:🚫 kick is not a valid RTMP service URL.Type of change
Checklist:
Test against a restream of Kick, Twitch and YouTube.
Other unrelated issue:
This fails for me on the Docker image so I ended up dropping the .log section. Might be busybox related however I;m not including that change as I haven't tested it against other OS's.