Conversation
Resolves error cases like
```
ENOENT: no such file or directory, unlink '/opt/iobroker/log/iobroker.2023-01-04.log'
Error: ENOENT: no such file or directory, unlink '/opt/iobroker/log/iobroker.2023-01-04.log'
at Object.unlinkSync (node:fs:1767:3)
at WriteStream.<anonymous> (/opt/iobroker/node_modules/winston-daily-rotate-file/daily-rotate-file.js:140:28)
at WriteStream.emit (node:events:525:35)
at WriteStream.emit (node:domain:489:12)
at finish (node:internal/streams/writable:756:10)
at finishMaybe (node:internal/streams/writable:741:9)
at afterWrite (node:internal/streams/writable:506:3)
at onwrite (node:internal/streams/writable:479:7)
at node:internal/fs/streams:416:5
at FSReqCallback.wrapper [as oncomplete] (node:fs:816:5)
```
foxriver76
left a comment
foxriver76
left a comment
There was a problem hiding this comment.
LGTM in general.
However, we should clarify the README part about the error handler or re-throw to match the behavior.
Not sure about the port to ES6 part or did you mean the arrow functions?
As written above I "Only" changed to lat/const and arrow functions ... ok not really es6 class because I'm not sure if this is compatible with the base "prototype" (aka winston-transport). This is an open topic for later |
|
@mattberther For the relöeases to work it would need a Github Actions secreat with name NPM_TOKEN with an npmjs automation token in there ... you could do with yours or we find a way how I can send you one |
|
@Apollon77 As mentioned in #388 , you should have admin access for the repo now to add your own secrets as you see fit... |
|
Thank you, then I will prepare the secret and merge here and then release a 5.0 ... then we are also safe and we can update ioBroker to proof it still working |
3 participants
This PR includes:
closes #366