Fix translatable-field collection for repeater groups and tab-organized nested forms - #118
Merged
LukeTowers merged 1 commit intoAug 21, 2026
Conversation
…ed nested forms getAutoTranslatableFields() merged group fields with a keyed union, so groups sharing a field name (e.g. blocks that all wrap their content in a 'data' nestedform) only had the first group's fields scanned. Scan each group separately instead. collectTranslatableFieldNames() did not descend into form.tabs.fields / form.secondaryTabs.fields, so nested forms that organize their fields in tabs were never collected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
LukeTowers
merged commit Aug 21, 2026
fc7e87d
into
wintercms:wip/auto-translate-copy
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while production-testing this branch as requested in #115. Two issues stopped
translatable: truefields from being picked up with real-world field definitions:getAutoTranslatableFields()merged group fields with a keyed union (+=). Block groups routinely all wrap their content in an identically-named nestedform (e.g.data), so only the first group's fields were scanned and every other block silently fell back to plain copy. Groups are now scanned separately.form.tabs.fields/form.secondaryTabs.fieldswere not descended into, so nested forms that organize fields in tabs never had their fields collected.Both verified end-to-end on our production field definitions (blocks repeater,
nl-BE→envia Google) and covered by regression tests (suite green: 18 tests, 27 assertions).🤖 Generated with Claude Code