fix(transitions): preserve same-document history traversal#17355
Open
farnoy wants to merge 1 commit into
Open
Conversation
When a navigate() was a sameDocument switch, prevent back/forward
navigation from triggering a view transition.
This change enables users to replaceState after a navigate() if they
want to remove an anchor from the URL without Astro triggering view
transitions later, during back/forward navigation.
await navigate("#top", {
history: "push",
...
});
history.replaceState(
history.state,
"",
window.location.pathname + window.location.search
);
🦋 Changeset detectedLatest commit: eaa29cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 396 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e22d0b1 to
eaa29cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a navigate() was a sameDocument switch, prevent back/forward navigation from triggering a view transition.
This change enables users to replaceState after a navigate() if they want to remove an anchor from the URL without Astro triggering view transitions later, during back/forward navigation.
Testing
navigate -> replaceStatetrick aboveDocs
Possibly needs to change https://docs.astro.build/en/reference/modules/astro-transitions/? but these history.replaceState tricks are not documented there to begin with.