Fix CSS missing when building from a symlinked directory#17356
Open
lazerg wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 009c697 The changes in this PR will be included in the next version bump. This PR includes changesets to release 396 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bb18ffc to
009c697
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
resolveRoot()usedpath.resolve(), which does not follow symlinks, soconfig.rootkept the symlink path while Vite/Rollup resolve module IDs to the real path (resolve.preserveSymlinksisfalse). ThepagesByViteIDkeys then never matched the Rollup module graph IDs, sogetPageDataByViteID()returnedundefinedand CSS was never associated with any page.resolveRoot()now runsfs.realpathSync()on the resolved path soconfig.rootmatches Vite's resolved IDs, with a try/catch fallback for a root that doesn't exist yet.Fixes #17319
Testing
test/symlink-css.test.ts, which builds the same fixture from its real directory and from a symlink to it and asserts the symlinked build has the same CSS as the real one. It fails onmain(the symlinked build has no CSS) and passes with the fix.Docs