Fix(js_scanner): import hoisting corruption when import.meta.env …#1158
Open
bosmievoll wants to merge 2 commits intowithastro:mainfrom
Open
Fix(js_scanner): import hoisting corruption when import.meta.env …#1158bosmievoll wants to merge 2 commits intowithastro:mainfrom
bosmievoll wants to merge 2 commits intowithastro:mainfrom
Conversation
…precedes import statements (withastro#944) Fix(js_scanner): track token positions in import.meta DotToken handler (withastro#944) The DotToken sub-loop in NextImportStatement consumed tokens via l.Next() without updating the position counter `i`, causing subsequent import statement spans to be offset. This corrupted the hoisted output when import.meta.env appeared before import statements. Two changes: - Capture consumed token lengths in the sub-loop and add to `i` - Add `continue` after ImportToken block to avoid double-counting Fixes withastro#944
🦋 Changeset detectedLatest commit: 3f26dd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…precedes import statements (#944)
Changes
Testing
Added 2 test cases to js_scanner_test.go:
Docs
Bug fix only — no public API changes.