Ci overhaul#1100
Closed
Leinnan wants to merge 28 commits into
Closed
Conversation
Owner
|
Thank you for putting together this PR. I've reviewed it carefully (with assistance from an AI tool to analyze the changes, though I was driving the review throughout) and wanted to share my thoughts. What I'm not merging:
What I've implemented separately:
These are straightforward improvements that don't require the structural changes in this PR. I appreciate the effort you put into this, but I'll be closing the PR. The changes don't align with how I want to manage the project's CI. |
Author
|
Sure thing 👍 I can disagree with some of the choices but I can totally see why you would decide not to use this PR, but rather treat it as starting point and have something that works better for you and makes project easier to maintain, not harder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce job duplication, compilation and processing of artifacts from jobs are put into justfile making it easier to run same commands on CI and locally.
Changes and reasoning