Skip to content

Ci overhaul#1100

Closed
Leinnan wants to merge 28 commits into
wolfpld:masterfrom
Leinnan:ci-overhaul
Closed

Ci overhaul#1100
Leinnan wants to merge 28 commits into
wolfpld:masterfrom
Leinnan:ci-overhaul

Conversation

@Leinnan

@Leinnan Leinnan commented Jul 16, 2025

Copy link
Copy Markdown

Reduce job duplication, compilation and processing of artifacts from jobs are put into justfile making it easier to run same commands on CI and locally.

Changes and reasoning

Change Reasoning Alternative
justfile Moving commands from CI yaml files into format that can be run locally makes it easier to have the same flow on local machine as in CI. I decided to use just to have more consistent behaviour on each major platform compared to subtle differences while using bash or makefile on different platforms (Yes, I am looking mostly on you, Windows). Make it makefile or bash scripts or just embed the commands back into the workflow files.
Unify CI workflows Reduced config repetition, reduce chance of fixing issue in one place, forgetting about the other, also added option to run workflows on demand manually. ?

@wolfpld

wolfpld commented Feb 19, 2026

Copy link
Copy Markdown
Owner

Thank you for putting together this PR. I've reviewed it carefully (with assistance from an AI tool to analyze the changes, though I was driving the review throughout) and wanted to share my thoughts.

What I'm not merging:

  1. Justfile — Tracy already has a build system that works well. Adding another layer of abstraction doesn't solve a problem for this project, and introduces an additional dependency for contributors.
  2. Arch Linux → Ubuntu switch — I prefer Arch Linux as the build environment for this project.
  3. Emscripten as a "webBuild" flag — Emscripten is a platform, not a special build mode. It should remain a first-class entry alongside Windows, macOS, and Linux, not demoted to a boolean flag on Ubuntu.
  4. Parallel component builds — The setup overhead (checkout, dependency installation, etc.) would be non-negligible compared to build time. The current sequential approach is simpler and more portable to non-GitHub CI environments.
  5. Workflow consolidation — Merging the workflow files would replace clear, self-contained files with one file riddled with conditionals. The small reduction in lines of code doesn't justify the increase in complexity.

What I've implemented separately:

  • Added workflow_dispatch to enable manual CI triggers.
  • Added CPM dependency caching using actions/cache@v4

These are straightforward improvements that don't require the structural changes in this PR.

I appreciate the effort you put into this, but I'll be closing the PR. The changes don't align with how I want to manage the project's CI.

@wolfpld wolfpld closed this Feb 19, 2026
@Leinnan

Leinnan commented Feb 20, 2026

Copy link
Copy Markdown
Author

Sure thing 👍 I can disagree with some of the choices but I can totally see why you would decide not to use this PR, but rather treat it as starting point and have something that works better for you and makes project easier to maintain, not harder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants