fix: replace date() with gmdate() and rand() with wp_rand() - #211
Open
masteradhoc wants to merge 2 commits into
Open
fix: replace date() with gmdate() and rand() with wp_rand()#211masteradhoc wants to merge 2 commits into
date() with gmdate() and rand() with wp_rand()#211masteradhoc wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Replace PHP native
date()with WordPress'sgmdate()andrand()withwp_rand()across Settings.php and Order.php.date()is affected by the server's runtime timezone and can produce inconsistent timestamps depending on the environment.gmdate()always outputs UTC, which is what WordPress expects internally.rand()is PHP's native PRNG and is flagged by WordPress coding standards.wp_rand()is the recommended drop-in replacement.These changes resolve 12 PHPCS errors (
WordPress.DateTime.RestrictedFunctions.date_dateandWordPress.WP.AlternativeFunctions.rand_rand) and move towards resolving #209.Related to #209.
Other information:
Changelog entry
FOR PR REVIEWER ONLY: