Merge pull request #4461 from woocommerce/dev/PCP-6294-mexico-enable-installments-not-visible-on-overview-tab-in-section-feautres

fix(todos): prevent dismissed items reappearing when dismissing multiple todos (6294)

Author: Dinamiko

modules/ppcp-settings/resources/js/data/todos/actions.js

@@ -111,6 +111,15 @@ export function refresh() {
 	};
 }
 
+export function addDismissedTodo( todoId ) {
+	return async ( { select, dispatch } ) => {
+		const current = select.getDismissedTodos() || [];
+		if ( ! current.includes( todoId ) ) {
+			await dispatch.setDismissedTodos( [ ...current, todoId ] );
+		}
+	};
+}
+
 export function resetDismissedTodos() {
 	return async ( { dispatch } ) => {
 		try {

modules/ppcp-settings/resources/js/data/todos/hooks.js

@@ -38,7 +38,7 @@ const useStoreData = () => {
 
 const useHooks = () => {
 	const { dispatch, select } = useStoreData();
-	const { fetchTodos, setDismissedTodos, setCompletedTodos } = dispatch;
+	const { fetchTodos, addDismissedTodo, setCompletedTodos } = dispatch;
 
 	// Get todos data from store
 	const todos = select.getTodos();
@@ -47,12 +47,7 @@ const useHooks = () => {
 
 	const dismissedSet = new Set( dismissedTodos );
 
-	const dismissTodo = async ( todoId ) => {
-		if ( ! dismissedSet.has( todoId ) ) {
-			const newDismissedTodos = [ ...dismissedTodos, todoId ];
-			await setDismissedTodos( newDismissedTodos );
-		}
-	};
+	const dismissTodo = ( todoId ) => addDismissedTodo( todoId );
 
 	const setTodoCompleted = async ( todoId, isCompleted ) => {
 		let newCompletedTodos;