Remove redundant cache from ReferenceTransactionStatus (6280)#4309
Merged
danieldudzic merged 3 commits intoApr 28, 2026
Conversation
danieldudzic
requested review from
AlexP11223,
Dinamiko,
Narek13,
hmouhtar,
mmaymo and
stracker-phil
as code owners
April 28, 2026 12:01
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. 🔗 Test this pull request with WordPress Playground What's included:
Login credentials:
Plugin Details:
🤖 Auto-generated for commit 6441670 • Last updated: 2026-04-28T13:00:00.894Z |
Narek13
approved these changes
Apr 28, 2026
Narek13
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 👍 Thanks a lot for adding the unit test!
danieldudzic
deleted the
dev/PCP-6280-remove-redundant-cache-from-reference-transaction-status
branch
April 28, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the redundant cache from
ReferenceTransactionStatusand rely onPartnersEndpoint::seller_status(), which already caches theSellerStatusobject.This cache is a leftover from the old
BillingAgreementsEndpoint(removed in #3495), where it made sense because the check required an expensivecreate_token()API call.Now that the class reads from
PartnersEndpoint::seller_status(), which already caches theSellerStatusobject in its own transient, the extra cache is redundant.This change:
woocommerce_paypal_payments_seller_statuseffective on repeated callsWCGatewayModule