Enhanced order decline reason detection via processor response object integration (6061)#4314
Merged
Conversation
mmaymo
requested review from
AlexP11223,
Dinamiko,
Narek13,
danieldudzic,
hmouhtar and
stracker-phil
as code owners
April 29, 2026 06:52
mmaymo
changed the title
Dinamiko
requested changes
Apr 30, 2026
Comment on lines
+352
to
+358
| $decline_message = ( $fraud && $fraud->response_code() ) | ||
| ? sprintf( | ||
| /* translators: %s - processor response code and description */ | ||
| __( 'Payment declined by card processor: %s. Please use a different payment method or contact your bank.', 'woocommerce-paypal-payments' ), | ||
| $fraud->get_response_code_message() | ||
| ) | ||
| : __( 'Payment provider declined the payment, please use a different payment method.', 'woocommerce-paypal-payments' ); |
Collaborator
There was a problem hiding this comment.
This exact message is duplicated in PaymentsStatusHandlingTrait.php, consider adding a helper on the entity (e.g. FraudProcessorResponse::get_customer_decline_message(): string) so in the future requires touching only one place.
Comment on lines
92
to
103
| $wc_order->add_order_note( | ||
| sprintf( | ||
| /* translators: %s - processor response code and description */ | ||
| __( 'PayPal payment declined. Processor response: %s', 'woocommerce-paypal-payments' ), | ||
| $fraud->get_response_code_message() | ||
| ) | ||
| ); | ||
| } | ||
| $wc_order->update_status( | ||
| 'failed', | ||
| __( 'Could not capture the payment.', 'woocommerce-paypal-payments' ) | ||
| ); |
Collaborator
There was a problem hiding this comment.
This code calls add_order_note and then update_status which also writes a status-change note, consider passing the $note argument of update_status() instead, e.g.:
$wc_order->update_status(
'failed',
$fraud && $fraud->response_code()
? sprintf( __( 'Could not capture the payment. Processor response: %s', '…' ), $fraud->get_response_code_message() )
: __( 'Could not capture the payment.', '…' )
);
Comment on lines
+177
to
+185
| $fraud_result = $wc_order->get_meta( PayPalGateway::FRAUD_RESULT_META_KEY ); | ||
| if ( empty( $fraud_result['response_code'] ) ) { | ||
| return; | ||
| } | ||
| $fraud = new FraudProcessorResponse( | ||
| $fraud_result['avs_code'] ?? null, | ||
| $fraud_result['cvv2_code'] ?? null, | ||
| $fraud_result['response_code'] | ||
| ); |
Collaborator
There was a problem hiding this comment.
Here it instantiates a full FraudProcessorResponse from stored meta only to call get_response_code_message() below. The avs/cvv args are not used for output here, consider reusing FraudProcessorResponseFactory::from_paypal_response( (object) $fraud_result ) instead.
Dinamiko
approved these changes
May 4, 2026
Dinamiko
deleted the
PCP-6061-enhanced-order-decline-reason-detection-via-processor-response-object-integration
branch
May 4, 2026 12:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #
Ticket:
Slack Thread:
Description
Adds response_code support to FraudProcessorResponse, parsing it from PayPal's capture response and mapping it
to human-readable descriptions. When a capture is declined, the processor response code is now
surfaced in the customer-facing exception message, the WC order note —
replacing the previous generic "payment declined" message wherever a specific code is available.
Steps to Test
Pay with creditcard failed transaction test numbers
Observe message in checkout indicating failure reason
Observe order note indicating failure reason
Changelog Entry
Added - enhanced order decline reason detection via processor response object integration
Closes # .