First-party Woo plugin detection for product customizations by strangerkir · Pull Request #4552 · woocommerce/woocommerce-paypal-payments

strangerkir · 2026-07-22T12:35:24Z

Description

Provides two services for:

detecting which plugins of the listed below are active
finding all products related to one of those plugins

Steps to Test

Install and activate plugins from the list below
Import products from the attached file
Install and activate the attached plugin
Run wp ppcp-compat-products scan
Make sure that all 8 plugins are reported as active, and 8 products are reported as affected - one per plugin

Plugins list

Products to import
wc-product-export-22-7-2026-1784711315948.csv

Plugin for testing
ppcp-compat-products.zip

Documentation

This PR needs documentation (has the "Documentation" label).
So far, only internal documentation is needed. This PR doesn't produce any visible changes; it only registers services which aren't used yet.

Notes

Failing CI was a pre-existing issue, so I'm ignoring it here to avoid scope creep

stracker-phil · 2026-07-22T15:41:14Z

+	 */
+	public function test_all_false_when_no_plugin_is_active(): void {
+		$this->plugin_detector->shouldReceive( 'scan' )->once()->andReturn( $this->all_inactive() );
+		$this->logger->shouldNotReceive( 'warning' );


suggestion: Remove this

Reason: Log output should not be tested/expected; when we add or change log output, it should not impact the test

Usual mock for the logger:

// Define the logger with shouldIgnoreMissing in the setUp() method, then forget about it: $this->logger = Mockery::mock(LoggerInterface::class)->shouldIgnoreMissing();

I'd still keep it tested from a practical point of view. If a 3rd-party API changes and the function no longer exists, this warning is the only way to know that the check itself was a false negative. So I'd say this is an important part of the logic, not just regular logging.

But I agree that testing for a particular string in logs may be too much, so I'm leaving just a warning assertion, without any message checks.

UPD: removed here, this one is useless, as we never examine real 3rd-party functions here. My comment above related to the next warning assertion.

stracker-phil · 2026-07-22T15:47:59Z

+/**
+ * Interface PluginDetectorInterface
+ */
+interface PluginDetectorInterface {


suggestion: Delete this interface

Reason: I cannot see any hint that there will be more than one implementation of this interface. Instead of adding it right away, we generally try starting with a single class and add an interface once it's really needed

Removed 👍

stracker-phil · 2026-07-22T15:49:41Z

+	/**
+	 * @inheritDoc
+	 */


nit: Remove the docblock

Reason: it's 100% noise, adding no value. PhpStorm expands the parent docblock automatically.

Of course, if the interface is removed (as I suggested), move the original docblock here 😉

Done. The interface was removed, and I only left the file header here, removing the class docblock. It looks like in this project we often prefer file headers, so I followed the same pattern.

stracker-phil · 2026-07-22T15:50:17Z

+	/**
+	 * Checks whether WooCommerce Subscriptions is active.
+	 *
+	 * @return bool
+	 */


nit: Remove all the docblocks in this file.

Reason: the return value is documented in code. And the function names are excellent, they do not need any explanation

Agree, this is nothing more than noise. Removed now.

stracker-phil · 2026-07-22T15:52:05Z

+ * @package WooCommerce\PayPalCommerce\Compat\PluginDetector
+ */
+
+declare(strict_types=1);


nit: apply code style rules to this file

Reason: The project style expects spaces around operators and parentheses

Sample:

declare( strict_types = 1 );

Fixed, thanks

stracker-phil · 2026-07-22T15:52:34Z

+/**
+ * Class ProductCustomizationDetector
+ */


nit: Remove this docblock

😉

stracker-phil · 2026-07-22T15:53:02Z

+	/**
+	 * @var PluginDetectorInterface
+	 */


nit: Remove the docblock, and the others that just re-state what's visible in the code

Removed completely :)

stracker-phil · 2026-07-22T15:54:27Z

+	/**
+	 * Cached result of $plugin_detector->scan(), since plugin activation
+	 * cannot change within a request but scan() may be called once per product.
+	 *
+	 * @var array<string, bool>|null
+	 */


note: This @var annotation is good, it this docblock should stay

(just want to point out that this is different/useful in contrast to the comments above)

stracker-phil · 2026-07-22T16:00:03Z

+			'woocommerce-subscriptions'        => $this->is_woocommerce_subscriptions_active(),
+			'woocommerce-gift-cards'           => $this->is_woocommerce_gift_cards_active(),
+			'woocommerce-product-bundles'      => $this->is_woocommerce_product_bundles_active(),
+			'woocommerce-product-addons'       => $this->is_woocommerce_product_addons_active(),
+			'woocommerce-min-max-quantities'   => $this->is_woocommerce_min_max_quantities_active(),
+			'woocommerce-composite-products'   => $this->is_woocommerce_composite_products_active(),
+			'woocommerce-shipping-per-product' => $this->is_woocommerce_shipping_per_product_active(),
+			'woocommerce-deposits'             => $this->is_woocommerce_deposits_active(),


idea: turn these strings into public consts

Reasons:

Allows auto-completion in the IDE

Avoids typos

Gives us a single place with the full detection-catalog

Good point, thanks! Done.

stracker-phil · 2026-07-22T16:02:41Z

+
+		$addons = \WC_Product_Addons_Helper::get_product_addons( $product->get_id(), false, false, false );
+
+		return array() !== $addons;


nit: Rewrite as count( $addons ) > 0 or ! empty( $addons )

Reason: makes the decision a bit easier to understand

stracker-phil · 2026-07-22T16:05:21Z

+		$this->logger->shouldReceive( 'warning' )
+			->once()
+			->with(
+				Mockery::on(
+					static function ( string $message ) use ( $plugin ): bool {
+						return false !== strpos( $message, $plugin ) && false !== strpos( $message, 'does not exist' );
+					}
+				)
+			);


suggestion: Remove this logger expectation

Reason: Same as above, It's not helping with plugin stability and does not prevent a bug. If devs need additional or different logs, it should not require unit test changes.

The ->assertFalse() check below is exactly what this test should verify

I explained above why I'd rather keep this. But I'm open to a discussion if you really believe it shouldn't be here.

stracker-phil · 2026-07-22T16:12:33Z

+/**
+ * Class RuntimeException
+ */
+class RuntimeException extends \RuntimeException {


change: Find a unique name for this

Reason: This class shadows the native RuntimeException which can (and likely will) cause confusion. In the worst case, someone might think "we do not need this class" and delete it, breaking the ProductCustomizationDetector try-catch

(Claude suggests PluginApiChangedException or DetectionMethodNotFoundException)

Good point, renamed.

github-actions · 2026-07-22T17:49:54Z

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

🔗 Test this pull request with WordPress Playground

What's included:

✅ WordPress (latest)
✅ WooCommerce (latest)
✅ PayPal Payments plugin v4.1.1-pr4552-30003370841-gdc0467a (built from this PR)

Login credentials:

Username: admin
Password: password

Plugin Details:

Version: 4.1.1-pr4552-30003370841-gdc0467a
Commit: 98123db
Artifact: woocommerce-paypal-payments-4.1.1-pr4552-30003370841-gdc0467a

💡 The demo environment resets each time you refresh. Perfect for testing!

🔄 This link updates automatically with each new commit to the PR.

⚠️ This URL is valid for 30 days from when this comment was last updated.

_{🤖 Auto-generated for commit 98123db • Last updated: 2026-07-23T11:34:00.549Z}

…-product-customizations

Narek13 · 2026-07-23T10:14:22Z

-	 * @param PluginDetectorInterface $plugin_detector The plugin presence detector.
-	 * @param LoggerInterface         $logger The logger.
+	 * @param PluginDetector  $plugin_detector The plugin presence detector.
+	 * @param LoggerInterface $logger The logger.


I would also suggest to remove these comments as they do not convey any info

Agree, they are useless. Removed.

strangerkir added 5 commits July 21, 2026 14:32

Add checks for product-customizing plugins

915150c

Add product customization detector

862a280

Add stubs

5525860

Add services for new classes

d21caaa

Add tests

c74c639

strangerkir marked this pull request as ready for review July 22, 2026 13:17

strangerkir requested review from AlexP11223, Dinamiko, Narek13, danieldudzic, mmaymo and stracker-phil as code owners July 22, 2026 13:17

stracker-phil reviewed Jul 22, 2026

View reviewed changes

strangerkir added 2 commits July 22, 2026 19:37

Rename exception

2024016

Remove unneeded interfaces

a81fbc5

strangerkir added 3 commits July 22, 2026 20:54

Update comment

2f6deb4

Merge branch 'dev/develop' into dev/PCP-6704-woo-plugin-detection-for…

26a84bc

…-product-customizations

Remove useless comments

2728423

Narek13 reviewed Jul 23, 2026

View reviewed changes

strangerkir added 6 commits July 23, 2026 14:10

Fix code style

ef283de

Store plugin slugs in public constants

e70d623

Replace rest of the plugin names with constants

ed5bbbe

Replace rest of the plugin names with constants

0d96bca

Make sure a warning is logged

35dce42

Improve empty result check

98123db

strangerkir requested review from Narek13 and stracker-phil July 23, 2026 12:06


		$addons = \WC_Product_Addons_Helper::get_product_addons( $product->get_id(), false, false, false );

		return array() !== $addons;

Uh oh!

Conversation

strangerkir commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to Test

Documentation

Notes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

strangerkir Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stracker-phil Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

strangerkir Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stracker-phil Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stracker-phil Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

strangerkir Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test using WordPress Playground

What's included:

Login credentials:

Plugin Details:

Uh oh!

Narek13 Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

strangerkir commented Jul 22, 2026 •

edited

Loading

strangerkir Jul 23, 2026 •

edited

Loading

stracker-phil Jul 22, 2026 •

edited

Loading

strangerkir Jul 23, 2026 •

edited

Loading

stracker-phil Jul 22, 2026 •

edited

Loading

stracker-phil Jul 22, 2026 •

edited

Loading

strangerkir Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

Narek13 Jul 23, 2026 •

edited

Loading