Replace Stats and Reader likes screens with an adaptive SwiftUI grid - #25907
Merged
crazytonyli merged 4 commits intoAug 26, 2026
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33944 | |
| Version | PR #25907 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 0a161ad | |
| Installation URL | 4o09gj26qfit0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33944 | |
| Version | PR #25907 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 0a161ad | |
| Installation URL | 7t1iivq644fro |
The likers list (users who liked a post) rendered as a single full-width table everywhere, wasting space on iPad's regular width. Replace the Stats and Reader post-likes screens with one shared SwiftUI implementation that adapts to the horizontal size class: a single column on compact and an adaptive multi-column grid on regular. LikesListViewModel ports the post-likes fetch and pagination engine from LikesListController (cache-first first load, the +1s "before" cursor, and the excluded-IDs boundary logic), publishing the likes, total, loading, and error state. LikesListView renders both layouts from one LazyVGrid; LikeUserRowView is a visual port of LikeUserTableViewCell. Each row is a Button so VoiceOver and Switch Control get one labeled control per row, and the avatar scales with Dynamic Type. A single LikesListHostViewController wrapper replaces the two near-duplicate host controllers, owning the navigation title, per-feature analytics, and the user profile sheet. A small PostLikesServing protocol keeps the view model unit-testable. Notifications is out of scope and keeps the existing LikesListController path.
crazytonyli
force-pushed
the
task/cmm-2318-stats-improve-likes-list-on-ipad
branch
from
August 19, 2026 06:28
260bc46 to
cfc6310
Compare
crazytonyli
marked this pull request as ready for review
August 19, 2026 06:36
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
jkmassel
requested changes
Aug 21, 2026
| }() | ||
|
|
||
| self.isLoadingPage = false | ||
| self.error = ErrorViewModel(title: self.errorTitle, subtitle: subtitle) |
Contributor
There was a problem hiding this comment.
When the list is already showing names and a load then fails, all the names disappear and you're stuck on an error screen with no way to retry — you have to back out and reopen. It should keep the names it already loaded.
How to see it:
- Open the likes on a post with more than 90 likes.
- Scroll to the bottom so it starts loading more.
- As it starts loading, drop your connection (turn off wifi).
- The load fails and every name you were just looking at vanishes behind the error.
The old screen kept the names on screen here. When there's no connection from the start, the code already keeps the cached names (the check just above this) — the fix is to do the same when a load fails. The error could show up as a banner at the top with a retry action on it?
A failed or offline refresh used to replace the whole likes list with a full-screen error, discarding names that were already showing and leaving no way to retry. The view now reserves the full-screen error (with a new Retry button) for the case where nothing is loaded; otherwise the loaded likes stay on screen and the failure renders as an inline footer with a Retry action in place of the loading spinner. The view model clears the error whenever a fetch starts so a retry returns to the loading state, and the offline path surfaces the same error state regardless of whether cached likes exist, since the view decides the presentation.
jkmassel
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/a8c/issue/CMM-2318
This PR introduces a grid view to display the like list The one in Stats is used to display Reader post like list too, so both places are updated.
Grid view is used on wider screens. Plain list is used on smaller screens. They reuse a new SwiftUI implementation underneath.