Skip to content

Show the selected period on snapshot stats detail screens - #25918

Merged
crazytonyli merged 2 commits into
trunkfrom
bugfix/cmm-2319-detail-period-labels
Aug 24, 2026
Merged

Show the selected period on snapshot stats detail screens#25918
crazytonyli merged 2 commits into
trunkfrom
bugfix/cmm-2319-detail-period-labels

Conversation

@crazytonyli

@crazytonyli crazytonyli commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes https://linear.app/a8c/issue/CMM-2319.

The issue description is not accurate, because I misunderstood the chart. The date range control is visible at screen level (the first two screenshots in the Linear issue) and chart level (the third screenshot). What is not clear is some stats screens do not display the range.

Before After
IMG_2821 IMG_2824
IMG_2822 IMG_2825
IMG_2823 IMG_2826

@crazytonyli
crazytonyli requested a review from jkmassel August 20, 2026 07:37
@crazytonyli crazytonyli added this to the 27.3 milestone Aug 20, 2026
@crazytonyli
crazytonyli marked this pull request as ready for review August 20, 2026 07:37
@wpmobilebot

wpmobilebot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number33891
VersionPR #25918
Bundle IDorg.wordpress.alpha
Commit5b2cfd8
Installation URL0n8vjusc11hso
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

wpmobilebot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number33891
VersionPR #25918
Bundle IDcom.jetpack.alpha
Commit5b2cfd8
Installation URL4frddfmbb72b0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@crazytonyli
crazytonyli added this pull request to the merge queue Aug 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Aug 23, 2026
Formatting-only pass produced by the repository's swift-format hook on
ReferrerStatsView, ExternalLinkStatsView, and ArchiveStatsView, committed
separately to keep the subsequent change reviewable.
The Referrer, External Link, and Archive detail screens display a
range-scoped views total, but nothing on screen states which period the
number covers; the date range is frozen at push time and these screens
have no fetch path, so they cannot host the interactive date range
control. Add an optional dateInterval to StandaloneMetricView (used only
by these three screens) that renders the formatted period as a secondary
line under the value.

The ReferrerStatsView preview mock now uses .last7Days so the preview
exercises a date-style period label instead of a bare year.

Part of CMM-2319.
@crazytonyli
crazytonyli force-pushed the bugfix/cmm-2319-detail-period-labels branch from a0c8e18 to 5b2cfd8 Compare August 23, 2026 22:14
@crazytonyli
crazytonyli enabled auto-merge August 23, 2026 22:14
@wpmobilebot

Copy link
Copy Markdown
Contributor

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

@crazytonyli
crazytonyli added this pull request to the merge queue Aug 24, 2026
Merged via the queue into trunk with commit f542174 Aug 24, 2026
30 checks passed
@crazytonyli
crazytonyli deleted the bugfix/cmm-2319-detail-period-labels branch August 24, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants