Added the Skip Button to ReaderDiscoverViewController - #25921
Merged
jkmassel merged 4 commits intoAug 21, 2026
Conversation
Vivek09Chahal
changed the title
6 tasks
jkmassel
added a commit
that referenced
this pull request
Aug 24, 2026
Follow-up to #25921 addressing review findings: - Track a `select_interests_skipped` event; skip was the one interest-selection outcome with no analytics, so the funnel could not distinguish it from an abandonment. - Disable the button on first tap to debounce, matching the primary button; a fast double-tap could otherwise re-run the Discover flow's dismiss and forced stream sync. - Call `readerDiscoverFlowDelegate?.didCompleteReaderDiscoverFlow()` on skip so a flow that both shows Skip and sets the delegate completes. Inert today — the only Skip flow (Discover) leaves the delegate nil.
pull Bot
pushed a commit
to kliu/WordPress-iOS
that referenced
this pull request
Aug 25, 2026
…ols (wordpress-mobile#25924) * Reader: Harden the interest-selection Skip button Follow-up to wordpress-mobile#25921 addressing review findings: - Track a `select_interests_skipped` event; skip was the one interest-selection outcome with no analytics, so the funnel could not distinguish it from an abandonment. - Disable the button on first tap to debounce, matching the primary button; a fast double-tap could otherwise re-run the Discover flow's dismiss and forced stream sync. - Call `readerDiscoverFlowDelegate?.didCompleteReaderDiscoverFlow()` on skip so a flow that both shows Skip and sets the delegate completes. Inert today — the only Skip flow (Discover) leaves the delegate nil. * Reader: Add debug menu controls to re-show the interests screen The select-interests screen is a one-time onboarding prompt gated by `readerDidSelectInterestsKey` and an `isFollowingInterests` check, which makes it hard to see again during development. Adds two internal-only Developer menu actions: - Show Reader Interests Screen — presents the `.discover` screen directly, bypassing both gates so it can be inspected on any account. - Reset Reader Interests Prompt — clears `readerDidSelectInterestsKey` so the real auto-prompt can fire again on the next Discover visit. * Reader: Make the reset-interests debug confirmation legible in dark mode The debug menu's shared `showSuccessNotice()` posts a bare "✅" emoji, which is illegible against the notice's inverted (light-in-dark-mode) background. Post a text confirmation for the Reset Reader Interests Prompt action instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Open Issue: #25911
Before on the first Time opening of the discover page in the reader tab, forces user to choose a tag, without choosing tag it didn't allowing the user to move forward.
Added a Skip button below on the page.
Testing instructions