Fix: Make Transcript Constant Length#195
Merged
WizardOfMenlo merged 8 commits intoSep 17, 2025
Merged
Conversation
shreyas-londhe
force-pushed
the
sl/recursive-support
branch
from
September 11, 2025 06:52
c557cc3 to
efab41a
Compare
shreyas-londhe
marked this pull request as ready for review
September 11, 2025 10:42
CodSpeed Instrumentation Performance ReportMerging #195 will not alter performanceComparing Summary
|
Collaborator
|
Will do a more careful pass, but before merging let's do the following:
I think this should modularize the code a bit better, and be better for when @recmo 's refactoring goes live. |
WizardOfMenlo
approved these changes
Sep 15, 2025
WizardOfMenlo
left a comment
Collaborator
There was a problem hiding this comment.
Approved, let's just move the parameters into whir_params and add some comments for future refactors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the recursive-verification flow by making the transcript length constant.
Problem
ark_crypto_primitives::MultiPathcompresses paths, producing variable-length serialization unsuitable for recursive circuits/witnessing.Solution
recursiveCargo feature to disable index sort/dedup (preserve order and multiplicity).FullMultiPath<P> (Vec<Path<P>>)with deterministic, fixed-size serialization.FullMultiPathunder recursive; default remainsMultiPath.