Fix runtime error that is not matched an argument type - #232
Open
SeunghoonBaek wants to merge 3 commits into
Open
Fix runtime error that is not matched an argument type#232SeunghoonBaek wants to merge 3 commits into
SeunghoonBaek wants to merge 3 commits into
Conversation
SeunghoonBaek
force-pushed
the
20200610_fix_runtime_error
branch
from
June 10, 2020 12:39
b6dde8c to
e391717
Compare
raedatoui
approved these changes
Jul 23, 2020
raedatoui
left a comment
raedatoui
left a comment
There was a problem hiding this comment.
oh i just opened a PR with the same change. ill approve yours and close mine :)
Author
|
Hey @raedatoui , Thanks for checking my change. |
|
it looks fine, it just needs approval from @worldveil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Comment
Hello
dejavumembers,I'm interesting in your audio fingerprint work.
I'm in diving your code for understanding what it works well. :)
I've found that the latest
dejavuhas a small runtime error while I tried to get an audio fingerprint.Please check this PR and let me know your opinion!
Thanks :)