Skip to content

fix: guard against undefined media in downloadMedia with helpful error messages #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wiliyam wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: guard against undefined media in downloadMedia with helpful error messages #2737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/api/whatsapp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,22 @@ export class Whatsapp extends BusinessLayer {
messageId = messageId.id;
}

if (!messageId) {
throw new Error(
'downloadMedia: messageId is undefined or null. ' +
'Make sure the message object (e.g. quotedMsgObj) exists before calling downloadMedia.'
);
}

return await evaluateAndReturn(
this.page,
async (messageId) =>
WPP.util.blobToBase64(await WPP.chat.downloadMedia(messageId)),
async (messageId) => {
const media = await WPP.chat.downloadMedia(messageId);
if (!media) {
throw new Error(`downloadMedia: no media found for message id "${messageId}". The message may not contain downloadable media.`);
}
return WPP.util.blobToBase64(media);
},
messageId
);
}
Expand Down