Fix error log during application deletion by reordering cache cleanup#3158
Draft
Tharsanan1 wants to merge 1 commit intowso2-extensions:6.14.xfrom
Draft
Fix error log during application deletion by reordering cache cleanup#3158Tharsanan1 wants to merge 1 commit intowso2-extensions:6.14.xfrom
Tharsanan1 wants to merge 1 commit intowso2-extensions:6.14.xfrom
Conversation
During service provider deletion, OAuthApplicationMgtListener.deleteAssociatedOAuthApps() deleted OAuth app data before cleaning cache entries. The cache cleanup calls OAuth2Util.isNonPersistentTokenEnabled() which looks up the OAuth app by consumer key, causing InvalidOAuthClientException since the app was already deleted. Reorder to clean cache entries before deleting OAuth app data so the lookup succeeds. Fixes: wso2/api-manager#4866 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
Comment on lines
+212
to
+214
| // Remove cache entries before deleting OAuth app data, since cache cleanup | ||
| // needs to look up app information that would no longer exist after deletion. | ||
| removeEntriesFromCache(associatedOAuthConsumerKeys); |
Contributor
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
Suggested change
| // Remove cache entries before deleting OAuth app data, since cache cleanup | |
| // needs to look up app information that would no longer exist after deletion. | |
| removeEntriesFromCache(associatedOAuthConsumerKeys); | |
| // Remove cache entries before deleting OAuth app data, since cache cleanup | |
| // needs to look up app information that would no longer exist after deletion. | |
| log.info("Removing cache entries for OAuth apps associated with application: " + serviceProvider.getApplicationName() + ", tenantDomain: " + tenantDomain); | |
| removeEntriesFromCache(associatedOAuthConsumerKeys); |
Contributor
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InvalidOAuthClientException: application.not.foundERROR log emitted when deleting applications from DevportalOAuthApplicationMgtListener.deleteAssociatedOAuthApps()deleted OAuth app data before cleaning cache entries. The cache cleanup callsOAuth2Util.isNonPersistentTokenEnabled()which tries to look up the OAuth app by consumer key — but the app was already deletedremoveEntriesFromCache()to run beforeremoveOAuthApplicationData()so the lookup succeeds while app data still exists in the databaseRelated Issue
Fixes wso2/api-manager#4866
Test plan
DELETE /api/am/devportal/v3/applications/{appId}InvalidOAuthClientExceptionorapplication.not.founderrors inwso2carbon.log🤖 Generated with Claude Code