Skip to content

Add connector configuration support for user-based SMS OTP resend blocking#72

Merged
HasiniSama merged 1 commit intowso2-extensions:mainfrom
HasiniSama:user-sms-blocking
Apr 7, 2026
Merged

Add connector configuration support for user-based SMS OTP resend blocking#72
HasiniSama merged 1 commit intowso2-extensions:mainfrom
HasiniSama:user-sms-blocking

Conversation

@HasiniSama
Copy link
Copy Markdown
Contributor

@HasiniSama HasiniSama commented Apr 7, 2026

Purpose

$subject

Related: #62

Add the below configuration to enable this:

[authentication.authenticator.sms_otp_local.parameters]
EnableUserBasedResendBlocking = "true"

Copy link
Copy Markdown

@wso2-engineering wso2-engineering bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Agent Log Improvement Checklist

⚠️ Warning: AI-Generated Review Comments

  • The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
  • Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.

✅ Before merging this pull request:

  • Review all AI-generated comments for accuracy and relevance.
  • Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
Comment Accepted (Y/N) Reason
#### Log Improvement Suggestion No: 1 N Redundant log.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.56%. Comparing base (f61120c) to head (bf98820).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...auth/smsotp/authenticator/SMSOTPAuthenticator.java 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #72      +/-   ##
============================================
- Coverage     63.68%   63.56%   -0.12%     
+ Complexity      293      289       -4     
============================================
  Files            26       26              
  Lines          1407     1408       +1     
  Branches        253      253              
============================================
- Hits            896      895       -1     
- Misses          430      432       +2     
  Partials         81       81              
Flag Coverage Δ
unit 38.75% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HasiniSama
Copy link
Copy Markdown
Contributor Author

Covering this specific method with a unit test provides minimal value because it does not contain any meaningful business logic or decision-making. The code simply retrieves a configuration value.

@HasiniSama HasiniSama merged commit 1c664db into wso2-extensions:main Apr 7, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants