Add config to control MCP path appending to backend endpoint URL#14223
Open
nisan-abeywickrama wants to merge 2 commits into
Open
Add config to control MCP path appending to backend endpoint URL#14223nisan-abeywickrama wants to merge 2 commits into
nisan-abeywickrama wants to merge 2 commits into
Conversation
nisan-abeywickrama
requested review from
AnuGayan,
Arshardh,
chamilaadhi and
tharindu1st
as code owners
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughAcross four distribution module velocity templates ( ChangesMCP Path Handling and Test Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14223 +/- ##
============================================
- Coverage 11.25% 9.30% -1.95%
+ Complexity 827 763 -64
============================================
Files 361 361
Lines 17719 17719
Branches 1897 1897
============================================
- Hits 1994 1649 -345
- Misses 15691 16043 +352
+ Partials 34 27 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nisan-abeywickrama
force-pushed
the
master
branch
from
5a5c778 to
d76a859
Compare
nisan-abeywickrama
force-pushed
the
master
branch
from
d76a859 to
111a76d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When the MCP path append feature flag is enabled,
/mcpwas unconditionally appended to MCP server backend endpoint URLs, causing 404 errors for MCP servers that don't expose a/mcppath segment. This change updates the Velocity templates to conditionally strip the URL postfix for MCP APIs based on themcpPathAppendedmetadata flag.Related issue: wso2/api-manager#5046
Approach
velocity_template.xml(all four distribution profiles:all-in-one-apim,api-control-plane,gateway,traffic-manager) — added a Velocity conditional block that removes theREST_URL_POSTFIXaxis2 property for MCP APIs when$mcpPathAppendedis nottrue. This ensures that when MCP path appending is disabled (the default), the gateway forwards requests to the backend URL as-is without appending/mcp.