Skip to content

Add support for disable account disable handler in identity.xml.j2#14225

Draft
manodyaSenevirathne wants to merge 2 commits into
wso2:masterfrom
manodyaSenevirathne:master
Draft

Add support for disable account disable handler in identity.xml.j2#14225
manodyaSenevirathne wants to merge 2 commits into
wso2:masterfrom
manodyaSenevirathne:master

Conversation

@manodyaSenevirathne

@manodyaSenevirathne manodyaSenevirathne commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This pull request introduces a new configuration option to the identity.xml.j2 template, allowing the DisableAccountDisableHandler setting to be specified if defined in the authentication policy.

Usage

In deployment.toml ,

[authentication_policy]
disable_account_disable_handler    = true

Merge after following PR

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ffb599d5-2820-4c11-90a5-86b3dc6f1ea9

📥 Commits

Reviewing files that changed from the base of the PR and between 60f1ac7 and 17c5fd4.

📒 Files selected for processing (4)
  • all-in-one-apim/pom.xml
  • api-control-plane/pom.xml
  • gateway/pom.xml
  • traffic-manager/pom.xml

📝 Walkthrough

Walkthrough

Templates in four product distribution modules now conditionally emit a DisableAccountDisableHandler XML element inside AuthenticationPolicy when authentication_policy.disable_account_disable_handler is defined. Additionally, four module pom.xml files bump carbon.identity.event.handler.account.lock.version from 1.11.0 to 1.11.1.

Changes

Identity Authentication Policy Configuration Update

Layer / File(s) Summary
Add DisableAccountDisableHandler to all product distributions
all-in-one-apim/modules/distribution/product/src/main/resources/conf/templates/repository/conf/identity/identity.xml.j2, api-control-plane/modules/distribution/product/src/main/resources/conf/templates/repository/conf/identity/identity.xml.j2, gateway/modules/distribution/product/src/main/resources/conf/templates/repository/conf/identity/identity.xml.j2, traffic-manager/modules/distribution/product/src/main/resources/conf/templates/repository/conf/identity/identity.xml.j2
Each identity.xml.j2 gains a conditional Jinja2 block that renders <DisableAccountDisableHandler>{{authentication_policy.disable_account_disable_handler}}</DisableAccountDisableHandler> inside AuthenticationPolicy when authentication_policy.disable_account_disable_handler is defined.
Bump account lock handler version in module poms
all-in-one-apim/pom.xml, api-control-plane/pom.xml, gateway/pom.xml, traffic-manager/pom.xml
The Maven property carbon.identity.event.handler.account.lock.version is incremented from 1.11.0 to 1.11.1 in each listed pom.xml.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding support for the disable account disable handler in identity.xml.j2 templates across multiple modules.
Description check ✅ Passed The description is directly related to the changeset, explaining the new configuration option, providing usage examples, and noting the dependency on a related PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 9, 2026
@manodyaSenevirathne manodyaSenevirathne marked this pull request as draft June 22, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants