Skip to content

Add config to enable auth for all mcp requests#14227

Open
msm1992 wants to merge 2 commits into
wso2:masterfrom
msm1992:master-mcp-1
Open

Add config to enable auth for all mcp requests#14227
msm1992 wants to merge 2 commits into
wso2:masterfrom
msm1992:master-mcp-1

Conversation

@msm1992

@msm1992 msm1992 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Related carbon-apimgt PR : wso2/carbon-apimgt#13858

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e0921357-da9d-4d47-a8dc-8dc1ef9184b6

📥 Commits

Reviewing files that changed from the base of the PR and between ff0279f and 535fd25.

📒 Files selected for processing (4)
  • all-in-one-apim/modules/distribution/product/src/main/resources/conf/default.json
  • api-control-plane/modules/distribution/product/src/main/resources/conf/default.json
  • gateway/modules/distribution/product/src/main/resources/conf/default.json
  • traffic-manager/modules/distribution/product/src/main/resources/conf/default.json

📝 Walkthrough

Walkthrough

Adds the boolean configuration property apim.mcp.enforce_auth_for_all_mcp_methods with a default value of true to the default.json files across the all-in-one APIM, API control plane, gateway, and traffic-manager distribution modules.

Changes

MCP Auth Enforcement Default Configuration

Layer / File(s) Summary
MCP auth enforcement default across distributions
all-in-one-apim/modules/distribution/product/src/main/resources/conf/default.json, api-control-plane/modules/distribution/product/src/main/resources/conf/default.json, gateway/modules/distribution/product/src/main/resources/conf/default.json, traffic-manager/modules/distribution/product/src/main/resources/conf/default.json
Adds apim.mcp.enforce_auth_for_all_mcp_methods set to true in all four distribution default configuration files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • chamilaadhi
  • tharindu1st
  • Arshardh
  • AnuGayan
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: adding a configuration property to enable authentication for all MCP requests across multiple modules.
Description check ✅ Passed The description provides a reference to the related carbon-apimgt PR, which contextualizes this change as part of a broader feature implementation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 18, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 18, 2026
RakhithaRR
RakhithaRR previously approved these changes Jun 22, 2026
@msm1992 msm1992 dismissed stale reviews from RakhithaRR and coderabbitai[bot] via 535fd25 June 23, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants